vtctl: MigrateServedTypes: Improve error messages and test coverage. #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM maybe rebuild the vtclt doc too (by running the python script in the doc directory). |
michael-berlin
force-pushed
the
vtctl_master_migration_error
branch
from
41b778e to
1b907b1
Compare
- If there are other types which must be migrated before MASTER, include them in the error message. - Before doing this check, always check first if the to be migrated type is actually listed in the "Shard" object.
- Mentioned parameters "cells" and "remove". - Clarified that it's an emergency function. - Changed example from multiple to a single served type.
michael-berlin
force-pushed
the
vtctl_master_migration_error
branch
from
1b907b1 to
e08f78a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.