Remove stats exports names overrides from mysqlctl.NewMysqld(). #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These names overrides are always set to 'Dba' and 'App', and even the comment before the function says that they should be set like that, so might as well hard code them. Different values were passed only in one place -- from tests to suppress publishing of stats. To achieve that I'm adding an extra parameter to mysqlctl.NewMysqld() that explicitly will be for suppressing publishing of the stats. I want to do this to avoid blowup of number of function parameters when I add a new type of db user.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These names overrides are always set to 'Dba' and 'App', and even the comment
before the function says that they should be set like that, so might as well
hard code them. Different values were passed only in one place -- from tests
to suppress publishing of stats. To achieve that I'm adding an extra parameter
to mysqlctl.NewMysqld() that explicitly will be for suppressing publishing of
the stats.
I want to do this to avoid blowup of number of function parameters when I add
a new type of db user.