Update to gRPC 1.0.0 and protobuf 3.0.0. #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks for doing this! |
|
@enisoc thanks, I'll address the pdo driver dependencies on monday |
enisoc
force-pushed
the
grpc
branch
3 times, most recently
from
87b9a54 to
186db84
Compare
|
FYI, this is all passing locally for me, but Travis is failing to build the gRPC PHP plugin. Still looking into why - the build error seems to be hidden by |
enisoc
force-pushed
the
grpc
branch
2 times, most recently
from
143cf6b to
b995ab0
Compare
enisoc
force-pushed
the
grpc
branch
2 times, most recently
from
e47b720 to
56686d3
Compare
|
Since PHP is segfaulting on Travis now even without this change (#2081), there's no need to hold this up on Travis PHP, so I'm going to submit this to unblock the conversion to gRPC 1.0. The PHP test on this PR branch passes in Docker. We'll work on fixing PHP in Travis separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2002
@Rastusik FYI