Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Andrew Mason to emeritus #17745

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Move Andrew Mason to emeritus #17745

merged 2 commits into from
Feb 12, 2025

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Feb 11, 2025

Description

Andrew is no longer active in the community. We thank him for his many contributions over several years.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@deepthi
move amason to emeritus
fc379d7 
Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 11, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 11, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 11, 2025
deepthi
deepthi commented Feb 11, 2025
View reviewed changes
MAINTAINERS.md
@@ -57,7 +56,7 @@ harshit-gangal
derekperkins, GuptaManan100, frouioui

### VTAdmin
ajm188, notfelineit
notfelineit, rohit-nayak-ps
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohit-nayak-ps I went ahead and added you here.

MAINTAINERS.md Outdated
@@ -33,7 +32,7 @@ rohit-nayak-ps, deepthi, mattlord
systay, harshit-gangal, vmg, GuptaManan100, dbussink

### Evaluation Engine
vmg
vmg, dbussink
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@systay should I add you to this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, why not?

.github/CODEOWNERS
Comment on lines +54 to +58
/go/vt/vtctl/grpcvtctldclient @notfelineit @mattlord
/go/vt/vtctl/grpcvtctldserver @notfelineit @mattlord
/go/vt/vtctl/reparentutil @GuptaManan100 @deepthi
/go/vt/vtctl/vtctldclient @notfelineit @mattlord
/go/vt/vtctld @deepthi @notfelineit @rohit-nayak-ps @mattlord
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohit-nayak-ps I wasn't sure whether I should add you to vtctl and vtadmin in this file. Please feel free to push a commit.

@deepthi deepthi requested a review from systay February 11, 2025 21:57
@deepthi deepthi added Component: Governance Type: Documentation and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 11, 2025
@systay
add systay to evalengine
970ae30 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi deepthi merged commit fa54e1d into vitessio:main Feb 12, 2025
101 checks passed
@deepthi deepthi deleted the ds-move-amason branch February 12, 2025 06:19
@deepthi deepthi mentioned this pull request Feb 22, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Component: Governance Type: Documentation
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@deepthi @systay @shlomi-noach @GuptaManan100 @rohit-nayak-ps