Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add some randomness to the ports used in VReplication e2e tests #17712

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Feb 6, 2025

Description

The vreplication_migrate workflow which runs the TestMigrateUnsharded and TestMigrateSharded tests has been a little flaky. The failures that I've seen are all related to port re-use. For example, from the most recent non-PR changes related failure:

2025-02-05T19:46:04.6078463Z F0205 19:45:45.485443   37959 grpc_server.go:305] Cannot listen on port 28192 for gRPC: listen tcp 127.0.0.1:28192: bind: address already in use
2025-02-05T19:46:04.6078885Z 
2025-02-05T19:46:04.6079010Z     cluster_test.go:661: 
2025-02-05T19:46:04.6079670Z         	Error Trace:	/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/cluster_test.go:661
2025-02-05T19:46:04.6080863Z         	            				/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/cluster_test.go:472
2025-02-05T19:46:04.6082094Z         	            				/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/migrate_test.go:260
2025-02-05T19:46:04.6083233Z         	            				/home/runner/work/vitess/vitess/go/test/endtoend/vreplication/migrate_test.go:229
2025-02-05T19:46:04.6083746Z         	Error:      	Received unexpected error:
2025-02-05T19:46:04.6084837Z         	            	process 'extcell1-1201' timed out after 10s (err: process 'extcell1-1201' exited prematurely (err: exit status 1))
2025-02-05T19:46:04.6085392Z         	Test:       	TestMigrateSharded

What makes this workflow and its tests somewhat unique is that each test creates two Vitess clusters (each with its own etcd server). So there was a fair amount of port re-use. So if there was any parallelism on the host or we failed to kill one of the test processes at the end we'd encounter a failure due to trying to bind to a port that's already in use.

This PR tries to address (or at least mitigate) the issue by adding some randomness to the ports used.

I re-ran the workflow 20 times here to confirm that we saw no failures, and we did not: https://github.com/vitessio/vitess/actions/runs/13186110424/job/36808474378?pr=17712

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>
Copy link
Contributor

vitess-bot bot commented Feb 6, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 6, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (10a6916) to head (2e6f38a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17712   +/-   ##
=======================================
  Coverage   67.94%   67.95%           
=======================================
  Files        1586     1586           
  Lines      255173   255173           
=======================================
+ Hits       173389   173402   +13     
+ Misses      81784    81771   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 6, 2025
@mattlord mattlord marked this pull request as ready for review February 6, 2025 23:37
@mattlord mattlord requested a review from deepthi as a code owner February 6, 2025 23:37
@rohit-nayak-ps rohit-nayak-ps merged commit b567098 into vitessio:main Feb 10, 2025
105 of 107 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the migrate_sharded_flakes branch February 10, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants