-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit test for go/yaml2/yaml.go #15027
Conversation
Signed-off-by: Divya Pamecha <21123621+Its-Maniaco@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
The code coverage is coming out to be 0%, I think it is because the test is not directly testing any function. |
Right, it is only covering variable declarations which I do not think count in the coverage report. I think it is fine as it is. |
Signed-off-by: Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15027 +/- ##
==========================================
- Coverage 65.49% 65.48% -0.01%
==========================================
Files 1562 1562
Lines 193940 193940
==========================================
- Hits 127016 127005 -11
- Misses 66924 66935 +11 ☔ View full report in Codecov by Sentry. |
Using `assert.Equal` for `Unmarshal` and added a `assert.NotEqual` Signed-off-by: Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Partial Fix to #14931
Covers unit test for
go/yaml2/yaml.go
The test file is not testing any function.