Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for go/yaml2/yaml.go #15027

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

Its-Maniaco
Copy link
Contributor

Partial Fix to #14931
Covers unit test for go/yaml2/yaml.go

image

The test file is not testing any function.

Signed-off-by: Divya Pamecha <21123621+Its-Maniaco@users.noreply.github.com>
@Its-Maniaco Its-Maniaco requested a review from deepthi as a code owner January 24, 2024 12:07
Copy link
Contributor

vitess-bot bot commented Jan 24, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 24, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Jan 24, 2024
@Its-Maniaco
Copy link
Contributor Author

The code coverage is coming out to be 0%, I think it is because the test is not directly testing any function.

@frouioui frouioui added Type: Testing Component: General Changes throughout the code base and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 24, 2024
@frouioui
Copy link
Member

The code coverage is coming out to be 0%, I think it is because the test is not directly testing any function.

Right, it is only covering variable declarations which I do not think count in the coverage report. I think it is fine as it is.

Signed-off-by: Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.48%. Comparing base (9d861f8) to head (c9dbf28).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15027      +/-   ##
==========================================
- Coverage   65.49%   65.48%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      193940   193940              
==========================================
- Hits       127016   127005      -11     
- Misses      66924    66935      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Using `assert.Equal` for `Unmarshal` and added a `assert.NotEqual` 

Signed-off-by: Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
@frouioui frouioui modified the milestones: v19.0.0, v20.0.0 Feb 6, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@harshit-gangal harshit-gangal merged commit 9be485f into vitessio:main Mar 5, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants