Update sql_builder.AfterPrevValues. #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use tuple-comparison instead of complex boolean expression. Add helper classes TupleGreater, TupleGreaterEqual, TupleLess, TupleLessEqual.
|
@aaijazi: PTAL |
|
LGTM Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
The MySQL optimizer does always find good indexes for:
('x', 'y') < (3, 4).
Therefore, while keeping the name TupleCompare, I am reverting
the SQL back to:
x = 3 AND y < 4 OR x < 3.
dumbunny
added a commit
that referenced
this pull request
Feb 9, 2016
Update sql_builder.AfterPrevValues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use tuple-comparison instead of complex boolean expression. Add
helper classes TupleGreater, TupleGreaterEqual, TupleLess, TupleLessEqual.
Note: AfterPrevValues is not used by clients yet.