-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-17.0] Upgrade the Golang version to go1.20.11
#14489
Merged
harshit-gangal
merged 3 commits into
release-17.0
from
upgrade-go-to-1.20.11-on-release-17.0
Nov 10, 2023
Merged
[release-17.0] Upgrade the Golang version to go1.20.11
#14489
harshit-gangal
merged 3 commits into
release-17.0
from
upgrade-go-to-1.20.11-on-release-17.0
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
dbussink
approved these changes
Nov 10, 2023
harshit-gangal
approved these changes
Nov 10, 2023
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
65c5fc7
to
c6459aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
go
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request bumps the Golang version to
go1.20.11
and the bootstrap version to18.5
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.11