Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/vt/mysqlctl: fix dup open/close backup stats #12947

Merged
merged 2 commits into from
May 30, 2023

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Apr 21, 2023

Description

Found a silly bug (in code I wrote) where the Destination:Close and Source:Close stats are being reported multiple times. Removing the duplications and adding a test.

Related Issue(s)

Fixes #12946

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Signed-off-by: Max Englander <max@planetscale.com>
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 21, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 21, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v17.0.0 milestone Apr 21, 2023
@maxenglander maxenglander changed the title go/vt/mysqlctl: fix dup close stats go/vt/mysqlctl: fix dup open/close backup stats Apr 21, 2023
@maxenglander maxenglander marked this pull request as ready for review April 21, 2023 13:17
@harshit-gangal harshit-gangal removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels May 8, 2023
@@ -51,7 +51,7 @@ import (
)

const (
builtinBackupEngineName = "builtin"
BuiltinBackupEngineName = "builtin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to export this? I see no usages outside the package.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh can't remember why I did this.. will revert

Signed-off-by: Max Englander <max@planetscale.com>
@maxenglander maxenglander requested a review from deepthi May 25, 2023 04:18
@deepthi deepthi merged commit 5cd5c90 into vitessio:main May 30, 2023
@deepthi deepthi deleted the maxeng-rm-dup-backupstats branch May 30, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: backup stats {Destination,Source}:Close reported too many times
3 participants