-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/vt/mysqlctl: fix dup open/close backup stats #12947
Conversation
Signed-off-by: Max Englander <max@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
@@ -51,7 +51,7 @@ import ( | |||
) | |||
|
|||
const ( | |||
builtinBackupEngineName = "builtin" | |||
BuiltinBackupEngineName = "builtin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to export this? I see no usages outside the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh can't remember why I did this.. will revert
Signed-off-by: Max Englander <max@planetscale.com>
Description
Found a silly bug (in code I wrote) where the
Destination:Close
andSource:Close
stats are being reported multiple times. Removing the duplications and adding a test.Related Issue(s)
Fixes #12946
Checklist