go/{vt,flags}: register builtin backup flags with vtbackup

[maxenglander]

Description

#12073 added support for backup read IO buffering but did not make the new flags available to the vtbackup binary. This PR enables that part.

Related Issue(s)

#12069

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation: content/en/docs/17.0: document vtbackup supports builtin backup engine website#1403

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

• Is it really necessary to add this flag?
• Flag names should be clear and intuitive (as far as possible)
• Help text should be descriptive.
• Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow should be required, the maintainer team should be notified.

Bug fixes

• There should be at least one unit or end-to-end test.
• The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

• There should be some code comments as to why things are implemented the way they are.

New/Existing features

• Should be documented, either by modifying the existing documentation or creating new documentation.
• New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• vtctl command output order should be stable and awk-able.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from VTop, if used there.

[ajm188]

LGTM. Do we need to back port this to 16? (I'm guessing no versions older than that since this wasn't added until after v15, is that correct?

[maxenglander]

@ajm188 ah I didn't think of that! But no backport needed if I understand how everything works, this is as yet unreleased, currently scheduled for v17.

[ajm188]

Ah i assumed that #12073 had been merged in time for v16 but i guess not. no back port needed, then

[deepthi]

website docs should be updated at https://vitess.io/docs/17.0/reference/programs/vtbackup/

[maxenglander]

@deepthi whoops that should have occurred to me. Added.