Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] Deprecate InitShardPrimary command #11557

Merged
merged 4 commits into from
Oct 21, 2022
Merged

[15.0] Deprecate InitShardPrimary command #11557

merged 4 commits into from
Oct 21, 2022

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Oct 21, 2022 •
edited
Loading

Description

Deprecate InitShardPrimary command in favour of PlannedReparentShard

Related Issue(s)

Checklist

Deployment Notes

@GuptaManan100
feat: deprecate initshardprimary
4b22d2d 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add summary docs
90a4f65 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 21, 2022 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@deepthi deepthi changed the title Deprecate InitSharPrimary command Deprecate InitShardPrimary command Oct 21, 2022
deepthi
deepthi reviewed Oct 21, 2022
View reviewed changes
go/vt/vtctl/reparent.go Outdated Show resolved Hide resolved
@GuptaManan100
feat: deprecate the correct command
d5dc5ee 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@deepthi deepthi mentioned this pull request Oct 21, 2022
Closed
100 tasks
@GuptaManan100 GuptaManan100 mentioned this pull request Oct 21, 2022
Merged
@GuptaManan100 GuptaManan100 changed the title Deprecate InitShardPrimary command [15.0] Deprecate InitShardPrimary command Oct 21, 2022
@GuptaManan100
test: fix expected output
0fbd23b 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@deepthi
Copy link
Member

deepthi commented Oct 21, 2022

Cluster(26) has been flaky. It's under investigation. Overriding the CI check to merge.

@deepthi deepthi merged commit 6b2208b into vitessio:release-15.0 Oct 21, 2022
@deepthi deepthi deleted the isp-deprecate branch October 21, 2022 21:38
GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Nov 2, 2022
@GuptaManan100
[15.0] Deprecate InitShardPrimary command (vitessio#11557)
cede02c 
* feat: deprecate initshardprimary

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add summary docs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: deprecate the correct command

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix expected output

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 mentioned this pull request Nov 2, 2022
Merged
3 tasks
GuptaManan100 added a commit that referenced this pull request Nov 2, 2022
@GuptaManan100
[15.0] Deprecate InitShardPrimary command (#11557) (#11620)
0e300fc 
* feat: deprecate initshardprimary

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add summary docs

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: deprecate the correct command

Signed-off-by: Manan Gupta <manan@planetscale.com>

* test: fix expected output

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@ajm188 ajm188 ajm188 approved these changes

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Forwardport to: main This will forward port the PR to the main branch Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @ajm188