Skip to content

[cli] [vtbackup] Migrate all vtbackup flags to pflag #11334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2022
Merged

[cli] [vtbackup] Migrate all vtbackup flags to pflag #11334

merged 5 commits into from
Sep 29, 2022

Conversation

rsajwani
Copy link
Contributor

@rsajwani rsajwani commented Sep 23, 2022 •
edited by ajm188
Loading

Signed-off-by: Rameez Sajwani rameezwazirali@hotmail.com

Description

Updates vtbackup related flag references specified in #11279

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@rsajwani
[cli] [vtbackup] Migrate all vtbackup flags to pflag
268fdf4 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 23, 2022 •
edited by ajm188
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@rsajwani
parsing flag for vtbackup
e685e0e 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani self-assigned this Sep 26, 2022
@rsajwani rsajwani added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management Component: CLI labels Sep 26, 2022
@rsajwani rsajwani marked this pull request as ready for review September 26, 2022 07:58
@rsajwani rsajwani requested a review from ajm188 as a code owner September 26, 2022 07:58
ajm188
ajm188 reviewed Sep 26, 2022
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nits, and some (i'm assuming) leftover debugging code that needs cleanup, but otherwise looking good

@rsajwani
code review feedback
1a93aa7 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@rsajwani rsajwani requested a review from deepthi as a code owner September 26, 2022 19:48
@rsajwani
rename method
87a074b 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
rsajwani
rsajwani commented Sep 28, 2022
View reviewed changes
go/vt/servenv/servenv.go
@@ -51,6 +48,8 @@ import (
"vitess.io/vitess/go/vt/logutil"
"vitess.io/vitess/go/vt/vterrors"

// register the HTTP handlers for profiling
_ "net/http/pprof"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this in next round of push

@maxenglander maxenglander mentioned this pull request Sep 28, 2022
Merged
@rsajwani
Merge remote-tracking branch 'upstream/main' into vtbackup_flags
66cde36 
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
@GuptaManan100 GuptaManan100 merged commit d1cd2a5 into vitessio:main Sep 29, 2022
@GuptaManan100 GuptaManan100 deleted the vtbackup_flags branch September 29, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees

@rsajwani rsajwani

Labels
Component: CLI Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch flag definitions to be on pflag instead of flag in package go/cmd/vtbackup
3 participants
@rsajwani @ajm188 @GuptaManan100