Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] Remove source-map-explorer dependency #10339

Merged
merged 2 commits into from
May 19, 2022

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 19, 2022

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

This removes the source-map-explorer dependency.

I do find it quite useful! But its infrequent update schedule means it tends to accumulate npm audit and Dependabot warnings. I use this package so seldomly that npm installing (with no save) when needed makes a lot more sense than keeping this in the package.json.

The main argument I see for keeping it in there would be if we wanted to integrate it into CI or something. Would be cool! But using something like https://github.com/bundlewatch/bundlewatch would be even cooler, without the dependency overhead. 😎 To consider for later.

Related Issue(s)

N/A

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

doeg added 2 commits May 19, 2022 08:11
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has the correct release notes label. release notes none should only be used for PRs that are so trivial that they need not be included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@ajm188 ajm188 merged commit d713833 into vitessio:main May 19, 2022
@doeg doeg deleted the sarabee-no-more-source-map-explorer branch May 19, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants