SchemaManager should be able to handle nil ShardInfo.MasterAlias. #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShardInfo.GetShard may contain nil MasterAlias because when creating a shard, or when scrapping the shard's master, the MasterAlias will be nil. SchemaManager should return error in such case instead of throwing a panic.
|
LGTM |
yaoshengzhe
added a commit
that referenced
this pull request
Aug 20, 2015
…as_in_schemamanager SchemaManager should be able to handle nil ShardInfo.MasterAlias.
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Sep 21, 2022
…ssio#11043) (vitessio#1012) When reloading the database schema, a query to fetch table information and tablespace information is executed. This query can take a long time when run on a mysql instance with many tables across many databases. We notice the impact of this query during database setup in our CI environments, as this query is executed on each DDL statement (and thus gets incrementally slower the more tables are being created). Performance of this query was improved before in vitessio#9632 by pre-filtering the rows of the `information_schema.innodb_sys_tablespaces` before joining them to rows from `information_schema.tables`, but that change was accidentally reverted in vitessio#10703. This brings back the pre-filtering. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShardInfo.GetShard may contain nil MasterAlias because when creating a shard,
or when scrapping the shard's master, the MasterAlias will be nil.
SchemaManager should return error in such case instead of throwing a panic.