Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NickAkhmetov/Copy requestInit when using from_dict #352

Merged
merged 1 commit into from
Jul 19, 2024
Merged

NickAkhmetov/Copy requestInit when using from_dict #352

merged 1 commit into from
Jul 19, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

This PR:

  • Updates VitessceConfig.from_dict() to avoid losing the requestInit data for datasets' files
  • Updates VitessceConfigDatasetFile to support initial requestInit configuration.
  • Updates VitessceConfigDataset.add_file to support initial requestInit configurations.

keller-mark
keller-mark approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@keller-mark keller-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@NickAkhmetov NickAkhmetov merged commit 31bd2cc into main Jul 19, 2024
10 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/copy-request-inits branch July 19, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keller-mark keller-mark keller-mark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NickAkhmetov @keller-mark