Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin class #350

Merged
merged 7 commits into from
Jul 24, 2024
Merged

Plugin class #350

merged 7 commits into from
Jul 24, 2024

Conversation

keller-mark
Copy link
Member

@keller-mark keller-mark commented Jul 8, 2024 •
edited
Loading

Fixes #347

TODO:

  • ensure VitessceConfig.add_view allows adding plugin views with names it does not know about
  • add example notebook using DemoPlugin class
  • allow for VitessceConfig.add_view to add view that lacks a dataset or dataset_uid?
  • document new plugin class API / usage
  • add test(s) for plugin API and the added VitessceWidget functionality

@keller-mark keller-mark marked this pull request as ready for review July 24, 2024 16:11
@keller-mark keller-mark merged commit 2e36cb2 into main Jul 24, 2024
10 checks passed
@keller-mark keller-mark deleted the keller-mark/plugin-class branch July 24, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define a plugin class/dataclass to couple on_config_change and anywidget.invoke handlers with plugin_esm
1 participant
@keller-mark