Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid using import.meta.url for relative assets if output is not ESM (fixes #9297) #9381

Merged
merged 7 commits into from
Aug 9, 2022
Merged

fix: avoid using import.meta.url for relative assets if output is not ESM (fixes #9297) #9381

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3ca6b49
fix(legacy): replace `import.meta.url` with `module.meta.url`
sapphi-red Jul 26, 2022
50baa27
refactor: remove polyfillImportMetaUrlPlugin
sapphi-red Jul 27, 2022
8f2065e
fix: avoid import.meta.url in non-ESM build
sapphi-red Jul 27, 2022
b894e57
refactor(worker): remove import.meta.url replace
sapphi-red Jul 27, 2022
1cdb135
test: worker asset url
sapphi-red Jul 27, 2022
da07e4c
test: skip inline worker with relative-base
sapphi-red Jul 27, 2022
4fa7190
Merge branch 'main' into fix/legacy-replace-import-meta
sapphi-red Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: skip inline worker with relative-base
  • Loading branch information
@sapphi-red
sapphi-red committed Jul 27, 2022
commit da07e4cce02666fe5d25cf68f61180f76bb13953
3 changes: 2 additions & 1 deletion playground/worker/__tests__/relative-base/relative-base-worker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ test('TS output', async () => {
await untilUpdated(() => page.textContent('.pong-ts-output'), 'pong', true)
})

test('inlined', async () => {
// TODO: inline worker should inline assets
test.skip('inlined', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside inline worker, self.location.href and import.meta.url are both blob:foobar or data:foobar. So new URL('./foo', import.meta.url) will become invalid URL.
Do we need to inline assets for inline workers? Or do we need to show an error for them? Or pass the current url into them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we treat inline workers like lib mode(should we make all the asset to base64)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can. But I'm not sure how this should be handled.

Also this will need much more work and since this wasn't working before this PR, I think we shouldn't include the change in this PR.

await untilUpdated(() => page.textContent('.pong-inline'), 'pong', true)
})

Expand Down