Skip to content

Conversation

@antfu
Copy link
Member

@antfu antfu commented May 7, 2022

Description

Continues #7650

Using regex is impossible to handle this correctly. For example

let a = ['`', "`", `'`, `"`]

While #7650 introduced a lexer for string templates, it does not cover well with mixing quotes.

I made https://github.com/antfu/strip-literal using acron's tokenizer to handle this correctly with the minimal overhead as possible. This also unblockers #7537

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu mentioned this pull request May 7, 2022
4 tasks
poyoho
poyoho previously approved these changes May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using createServer and trying to build in lib mode gives "[vite:worker-import-meta-url] can not match string template expression." error

5 participants