Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify required build before test #7389

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Conversation

j-maas
Copy link
Contributor

@j-maas j-maas commented Mar 20, 2022

Description

When I tried running the tests, I got a lot of error messages. It took me a while to figure out that this was because I hadn't built Vite.

Additional context

A previous issue (#4543) has already pointed out this dependency. It was proposed to add a note to the documentation, but if that happened I think it can be made even clearer.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the documentation Improvements or additions to documentation label Mar 20, 2022
ydcjeff
ydcjeff previously approved these changes Mar 21, 2022
CONTRIBUTING.md Show resolved Hide resolved
@patak-dev patak-dev merged commit d23f4ff into vitejs:main Mar 21, 2022
@j-maas j-maas deleted the patch-1 branch March 21, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants