Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): fix to use the browserslist configuration (fix #2476) #6880

Closed
wants to merge 1 commit into from

Conversation

erm1116
Copy link

@erm1116 erm1116 commented Feb 12, 2022

Description

fix #2476

This PR is from closed PR #2627.
When no targets options with @vite/legacy-plugin and if exists "the field of browserslist in package.json" or ".browserslistrc", use it as @babel/preset-env targets.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@naifen00
Copy link

When to fix it?

@erm1116
Copy link
Author

erm1116 commented Mar 29, 2022

@naifen00
Maybe, I think CI failing is not my problem... (other PR also fail some checks)
so I don't have any idea to fix this.

@Niputi
could you help me?
And have you made any progress on this PR?

@sapphi-red
Copy link
Member

Closing as #11318 was merged.

@sapphi-red sapphi-red closed this Mar 12, 2023
@erm1116 erm1116 deleted the fix-issue-2476 branch April 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-legacy does not use browserslistrc
4 participants