fix: improve error message for HTML compilation error (fix #5769) #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nurulhudaapon
force-pushed
the
fix/issue-5767
branch
from
f2c8b12
to
2543e16
Compare
|
which issue will this fix? 5769 is a pull request removing unnecessary code |
Improving the error message for the following issue. |
Shinigami92
previously approved these changes
Nov 21, 2021
Closed
7 tasks
7 tasks
Shinigami92
added
the
p2-nice-to-have
Niputi
previously approved these changes
Dec 18, 2021
|
@patak-dev would you review/merge? this is very neat for dev experience |
patak-dev
previously approved these changes
Dec 18, 2021
bluwy
previously approved these changes
Dec 19, 2021
patak-dev
dismissed stale reviews from bluwy, Niputi, Shinigami92, and themself
via
a4db074
patak-dev
reviewed
Dec 19, 2021
Niputi
approved these changes
Dec 19, 2021
patak-dev
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message was not to the point for HTML parsing error, adding meaningful message from
@vue/compiler-dom.CompilerErrorformatParseErrorhandleParseErrormethod with updated error message on HTML parsing errorRelated issue: #5767
Before:
After:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).