Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete useless condition #5772

Merged
merged 1 commit into from
Nov 20, 2021
Merged

chore: delete useless condition #5772

merged 1 commit into from
Nov 20, 2021

Conversation

sanyuan0704
Copy link
Contributor

@sanyuan0704 sanyuan0704 commented Nov 20, 2021 •
edited
Loading

Description

Delete useless condition !useConfig，because there is !mjs condition which means useConfig must be undefined.It will also make code clean after delete that useless condition.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sanyuan0704 sanyuan0704 changed the title chore: delete useless condition fix: delete useless condition Nov 20, 2021
@Niputi Niputi added the p1-chore Doesn't change code behavior (priority) label Nov 20, 2021
@sanyuan0704
Copy link
Contributor Author

@Niputi @Shinigami92 Please take a review.

@antfu antfu changed the title fix: delete useless condition chore: delete useless condition Nov 20, 2021
@antfu antfu merged commit 5588eb9 into vitejs:main Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanyuan0704 @antfu @Niputi