fix: replace server.origin in css plugin (fix #5408)#5571
Merged
patak-dev merged 2 commits intovitejs:mainfrom Nov 7, 2021
dbohn:fix-css-hmr-with-origin
Merged
fix: replace server.origin in css plugin (fix #5408)#5571patak-dev merged 2 commits intovitejs:mainfrom dbohn:fix-css-hmr-with-origin
patak-dev merged 2 commits intovitejs:mainfrom
dbohn:fix-css-hmr-with-origin
Conversation
Contributor
|
would be good if you are able to add a test so there won't be regression |
Contributor
Author
|
I've updated the existing tailwind playground to include the server origin clause. |
Shinigami92
approved these changes
Nov 6, 2021
patak-dev
approved these changes
Nov 7, 2021
This was referenced Nov 8, 2021
This was referenced Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull Request #5104 introduced the server.origin configuration option to set a base URL for static assets.
This was implemented by checking for this option in the
fileToDevUrlfunction of the assets plugin.This function is used by the css plugin as well when registering CSS files as build dependencies.
This lead to incorrect added watch dependencies and broke HMR for Tailwind as described in #5408
This PR fixes this issue by adding the server origin to the already present replace call, that removed the config.base, if the server.origin option is set and should fix #5408.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).