Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change esbuild compiler target to es2020 + bump esbuild + bu… #525

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented Jul 7, 2020

…mp rollup

close #503

@@ -82,6 +82,7 @@ export const registerAssets = (
) => {
for (const [fileName, source] of assets) {
bundle[fileName] = {
name: fileName,
isAsset: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need update by bump rollup

@hronro
Copy link
Contributor

hronro commented Jul 10, 2020

Hi @yyx990803, Is there anything blocks this PR being merged? I can not get vite works without this PR merged.

@yyx990803 yyx990803 merged commit 893eeff into vitejs:master Jul 10, 2020
@underfin underfin deleted the es2020 branch July 11, 2020 02:55
@sionzee
Copy link

sionzee commented Jul 16, 2020

@foisonocean
If you are using yarn then you can make it work adding:

  "resolutions": {
    "esbuild": "0.5.16"
  },

to package.json, it will probably take a while before next vite beta is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta doesn't work with esbuild since 0.5.17
4 participants