fix: sometimes THIS_IS_UNDEFINED warnings were still shown #4844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using current latest (
v.2.5.3
)vite
for building our project i was getting lot ofThe 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
errors in console.I've dived into sources, and found that here we have logic for filtering out such warnings, but here no
onwarn
provided at all.So I've fixed situation by reusage at node/plugins/worker function
onRollupWarning
exported from ./node/build.Using
npm pack
I've tried it on my side already, and having no moreTHIS_IS_UNDEFINED
warnings at console during building, as expectedAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).