Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format with prettier #2768

Merged
merged 4 commits into from
Mar 31, 2021
Merged

chore: format with prettier #2768

merged 4 commits into from
Mar 31, 2021

Conversation

Shinigami92
Copy link
Member

Description

Format the whole repo with yarn prettier --write .

Additional context

  • .github/commit-convention.md want's to have a leading semicolon in line 11
    I just ignored this one
  • In docs/guide/static-deploy.md I fixed/improved some indentations that will inline content into bullet-points
  • Most files just got an eol, if this is not wanted, we should configure it properly
  • Some files are ignored via .prettierignore

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Mar 29, 2021
@Shinigami92 Shinigami92 requested a review from patak-dev March 29, 2021 17:59
@Shinigami92 Shinigami92 self-assigned this Mar 29, 2021
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope we only need to do this for one time

@Shinigami92
Copy link
Member Author

Hope we only need to do this for one time

Yeah, we may use eslint . later in the pre-commit git-hook instead of the different file extensions
But this may need some more fine-tuning of e.g. .prettierignore

@patak-dev
Copy link
Member

@antfu do you think we can merge this one? I think that it will be good to get it in so @Shinigami92 doesn't need to keep updating it when there are new commits against main

@antfu
Copy link
Member

antfu commented Mar 31, 2021

Let's merge this. Changes are mainly markdowns so it should not introduce too many conflicts. Making things consistent can improve future review experiences.

@antfu antfu merged commit 5bf0509 into main Mar 31, 2021
@antfu antfu deleted the format-with-prettier branch March 31, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants