Repository navigation
Conversation
Contributor
|
This PR has been automatically flagged as likely to be created by a bot, LLM, or agent, and will be automatically closed. These contributions harm the maintenance of the project. Please read our AI policy for more information. If you believe this is a mistake, please reply to this comment and we will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23679
Since #23653
getHtmlFilename()strips the query, sotransformIndexHtml('/?foo=bar', html)gets the root directory asfilename.devHtmlHookonly checkedfs.existsSync(filename), which is true for a directory, so the URL was treated as a real HTML file and the inline<style>proxy module ended up withmod.file === '/', andensureWatchedFileadded/to the watcher.It now requires
filenameto be a file (tryStatSync(filename)?.isFile()), so this case goes back to the virtual\0proxy path it used before 8.3.3. I went with that over computingtrailingSlashfrom the stripped path, since/?foo=bar+index.htmlwould need extra handling to putindex.htmlbefore the query.Test in
indexHtml.spec.ts: callstransformIndexHtml('/?foo=bar', …)with an inline<style>and asserts no directory gets watched. Onmainit watches/.AI disclosure: I used an AI coding tool to help write this. I reviewed the change, checked the test fails without the fix, and ran the
packages/viteunit tests (no new failures).