Repository navigation
docs(config): correct the server.sourcemapIgnoreList default - #23462
Merged
bluwy merged 3 commits intoSep 22, 2026
Merged
Conversation
The documented default still described the pre-vitejs#23437 implementation, `sourcePath.includes('node_modules')`. Since vitejs#23437 the default is `isInNodeModules`, which only matches `node_modules` as a whole path segment. The sample was the most harmful part: it is labelled "This is the default value", so copying it into a config silently restores the substring match and puts a project's own sources back on the ignore list whenever the project path merely contains `node_modules` as part of a longer name. Claude-Session: https://claude.ai/code/session_01CBv9CTLkwDs3MuPiW3TQ6T
btea
previously approved these changes
Sep 18, 2026
bluwy
reviewed
Sep 22, 2026
bluwy
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23437, which changed
isInNodeModulesfrom a substring test to a whole-path-segment test.server.sourcemapIgnoreListdefaults to that function, so its documented default no longer matches the code.Three spots in that section still describe the old implementation: the Default: line, the sentence "excludes all paths containing
node_modules", and the example.The example is the one that actually bites. It is labelled "This is the default value", so copying it into a config restores the substring match — and a project living in, say,
~/work/node_modules_bug/puts its own sources back on thex_google_ignoreList, which is the DevTools symptom #17467 was about.The regex now shown in the docs is copied verbatim from
inNodeModulesREinpackages/vite/src/node/utils.ts, so the two can be diffed by eye.Docs only, no behaviour change.
pnpm run test-docsandpnpm format && git diff --exit-codeboth pass locally.https://claude.ai/code/session_01CBv9CTLkwDs3MuPiW3TQ6T