refactor: remove HmrUrl concept

[sapphi-red]

This PR removes the "HmrUrl" concept.

There were three "Url" concept in Vite:

• "ModuleUrl"
  • the URL used in the module graph.
  • does not replace \0
  • does not have base
  • Example: \0virtual:foo
• "BrowserUrl"
  • the URL used by the browser
  • replaces \0
  • has base
  • Example: /base/@id/__x00__virtual:foo?t=123
• "HmrUrl"
  • the URL used in the HMR client.
  • replaces \0
  • does not have base
  • Example: /@id/__x00__virtual:foo

It is confusing to have three kinds of representation. I think the HmrUrl is not needed as well.

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[sapphi-red]

acceptedPath is now "moduleUrl" so wrapId is needed to convert to "browserUrl".

[sapphi-red]

HmrClient received "moduleUrl" (Url without /@id/). acceptedPath and path is now "moduleUrl" (was "HmrUrl") so unwrapId is no longer needed.

[sapphi-red]

A simple rename here. This is/was a "moduleUrl" because unwrapId is called.

[sapphi-red]

HotContext now receives "moduleUrl" similarly to acceptedPath and path.

[sapphi-red]

The acceptPath of import.meta.hot.accept(acceptPath) now receives "moduleUrl", similarly to path and acceptPath. This is not a breaking change because this acceptPath argument is always rewritten by this import-analysis plugin.

[sapphi-red]

firstInvalidatedBy was "HmrUrl" (as it was sent from the client), but now it's "ModuleUrl".

[sapphi-red]

path and acceptedPath is now "moduleUrl" instead of "HmrUrl".

[sapphi-red]

This conversion happens on the client side when importing a module (i.e. when "moduleUrl" is converted to "browserUrl").

[sapphi-red]

This is a simple rename. This is/was a "moduleUrl" because unwrapId is called.

[sapphi-red]

As noted in this file and hmrPayload.d.ts, technically these fields will have slightly different behavior. But I assume this won't be a huge problem.

[sapphi-red]

/ecosystem-ci run

[pkg-pr-new]

Open in StackBlitz

@vitejs/plugin-legacy

pnpm add https://pkg.pr.new/@vitejs/plugin-legacy@23172 -D

npm i https://pkg.pr.new/@vitejs/plugin-legacy@23172 -D

yarn add https://pkg.pr.new/@vitejs/plugin-legacy@23172.tgz -D

vite

pnpm add https://pkg.pr.new/vite@23172 -D

npm i https://pkg.pr.new/vite@23172 -D

yarn add https://pkg.pr.new/vite@23172.tgz -D

commit: 5399f52

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 94cf41f: Open

suite	result	latest scheduled
react-router	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
qwik	⏹️ cancelled	⏹️ cancelled
storybook	❌ failure	✅ success
tanstack-start	⏹️ cancelled	⏹️ cancelled
vitest	❌ failure	❌ failure
astro	❌ failure	❌ failure

✅ vite-plugin-react, module-federation, marko, analogjs, vite-plugin-pwa, vite-plugin-svelte, unocss, laravel, vite-setup-catalogue, vite-plugin-cloudflare, vitepress, vite-plugin-vue, vuepress, vite-plugin-rsc, vite-environment-examples, quasar, waku, vike, nuxt

[sapphi-red]

^ storybook failure seems unrelated

[bluwy]

I like this refactor. Let's try this in the next minor and hope it doesn't break many people.

The base branch was changed.