Skip to content

test(resolve): add test for sass @use with node builtin name - #22514

Merged
sapphi-red merged 1 commit into
mainfrom
05-25-test_css_add_test_for_sass_use_with_node_builtin_name
May 25, 2026
Merged

sapphi-red merged 1 commit into
mainfrom
05-25-test_css_add_test_for_sass_use_with_node_builtin_name

Conversation

@shulaoda

Copy link
Copy Markdown
Member

Summary

Follow-up to #22509. Add e2e test covering the panic where vite build crashed with Can't call 'warn' on PluginContext::Napi when SCSS @uses a name clashing with a Node built-in (e.g. @use 'util').

The fixture mirrors the original reproduction (rolldown/rolldown#9414): component/button.scss does @use 'util' as * while util/ lives in a parent directory, so preferRelative cannot resolve it and the resolve plugin's node-builtin warn path is hit.

@shulaoda
shulaoda requested a review from sapphi-red May 25, 2026 06:12
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) test labels May 25, 2026
@sapphi-red
sapphi-red merged commit cff41d5 into main May 25, 2026
20 of 21 checks passed
@sapphi-red
sapphi-red deleted the 05-25-test_css_add_test_for_sass_use_with_node_builtin_name branch May 25, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority) test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants