Repository navigation
test(resolve): add test for sass @use with node builtin name - #22514
Merged
sapphi-red merged 1 commit intoMay 25, 2026
Merged
Conversation
sapphi-red
approved these changes
May 25, 2026
sapphi-red
deleted the
05-25-test_css_add_test_for_sass_use_with_node_builtin_name
branch
May 25, 2026 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #22509. Add e2e test covering the panic where
vite buildcrashed withCan't call 'warn' on PluginContext::Napiwhen SCSS@uses a name clashing with a Node built-in (e.g.@use 'util').The fixture mirrors the original reproduction (rolldown/rolldown#9414):
component/button.scssdoes@use 'util' as *whileutil/lives in a parent directory, sopreferRelativecannot resolve it and the resolve plugin's node-builtin warn path is hit.