Skip to content

feat: send 408 on request timeout #22476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
May 25, 2026
Merged

feat: send 408 on request timeout #22476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions packages/vite/src/node/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,19 +273,35 @@ export function setClientErrorHandler(
logger: Logger,
): void {
server.on('clientError', (err, socket) => {
let msg = '400 Bad Request'
if ((err as any).code === 'HPE_HEADER_OVERFLOW') {
msg = '431 Request Header Fields Too Large'
logger.warn(
colors.yellow(
'Server responded with status code 431. ' +
'See https://vite.dev/guide/troubleshooting.html#_431-request-header-fields-too-large.',
),
)
// https://github.com/nodejs/node/blob/v26.2.0/lib/_http_server.js#L992
let msg
switch ((err as any).code) {
case 'HPE_HEADER_OVERFLOW': {
msg = '431 Request Header Fields Too Large'
logger.warn(
colors.yellow(
'Server responded with status code 431. ' +
'See https://vite.dev/guide/troubleshooting.html#_431-request-header-fields-too-large.',
),
)
break
}
Comment thread
thatguystone marked this conversation as resolved.
case 'HPE_CHUNK_EXTENSIONS_OVERFLOW': {
msg = '413 Payload Too Large'
break
}
case 'ERR_HTTP_REQUEST_TIMEOUT': {
msg = '408 Request Timeout'
break
}
default: {
msg = '400 Bad Request'
break
}
}
if ((err as any).code === 'ECONNRESET' || !socket.writable) {
return
}
socket.end(`HTTP/1.1 ${msg}\r\n\r\n`)
socket.end(`HTTP/1.1 ${msg}\r\nConnection: close\r\n\r\n`)
})
}
Loading