Repository navigation
docs: clarify production build caching - #21980
lilianakatrina684-a11y wants to merge 1 commit into
Conversation
377b962 to
d65aa40
Compare
|
Hi @lilianakatrina684-a11y — the dev-cache vs production-build clarification here looks useful. While reading this paragraph I noticed an adjacent inaccuracy that would fit naturally into your edit if you're open to folding it in: the trailing sentence still reads
That doesn't match the actual resolution in if (config.cacheDir) {
cacheDir = path.resolve(resolvedRoot, config.cacheDir)
} else if (pkgDir) {
cacheDir = path.join(pkgDir, `node_modules/.vite`)
} else {
const nodeModulesDir = path.join(resolvedRoot, 'node_modules')
cacheDir = fs.existsSync(nodeModulesDir)
? path.join(nodeModulesDir, `.vite`)
: path.join(resolvedRoot, `.vite`)
}So the bare #23060 already corrected the JSDoc in
No worries if you'd rather keep this PR scoped to the build-caching clarification — just flagging it since it's the same paragraph. Happy to open a separate small PR if you prefer. |
|
The PR has been manually labeled as likely to be created by a bot, LLM, or agent, and will be automatically closed. This may be because the PR contains LLM-generated descriptions, does not follow the PR template, is overly verbose, or does not contain any fruitful interaction, which harms the review process. Please read our AI policy for more information. If you believe this is a mistake, please reply to this comment and we will review it. |
Summary
Closes #19214