Repository navigation
fix(html): handle trailing slash in transformIndexHtml pre-transform - #21872
Closed
XploitMonk0x01 wants to merge 2 commits into
Closed
XploitMonk0x01 wants to merge 2 commits into
XploitMonk0x01 wants to merge 2 commits into
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
sapphi-red
requested changes
May 21, 2026
sapphi-red
left a comment
sapphi-red
left a comment
Member
There was a problem hiding this comment.
We should have a test for vite.transformIndexHtml
refs #22480
3 tasks done
Member
|
closing as #22480 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18964
Normalizes relative URL pre-transform path resolution when htmlPath ends with /
Adds regression tests in packages/vite/src/node/server/middlewares/tests/indexHtml.spec.ts