Closed
Conversation
Wait for a START event before waiting for END, ensuring we track a fresh build cycle rather than a spurious rebuild from duplicate OS file notifications. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mplete" This reverts commit e92ec1d.
The dev server tests already use `usePolling: true` because native file watchers can miss fast edits, but the build watch tests were using the default native watcher. Apply the same polling config to build watch mode via the chokidar backward-compat option. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… tests The native file watcher (notify crate) runs in a separate thread, so the watcher can detect changes and fire START→END before the listener is attached. Fix by making notifyRebuildComplete a sync-returning function and calling it before editFile at all 4 test sites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/rolldown/rolldown/releases/tag/v1.0.0-rc.7