Skip to content

fix(module-runner): prevent crash on negative column in stacktrace #21585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AriPerkkio wants to merge 2 commits into
base: main
Choose a base branch
from
+42 −2
Open

fix(module-runner): prevent crash on negative column in stacktrace #21585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b26195
fix(module-runner): prevent crash on negative column in stacktrace
AriPerkkio Feb 7, 2026
b62a076
test: failing test for negative column in stacktrace
AriPerkkio Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/vite/src/module-runner/sourcemap/interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,8 @@ function wrapCallSite(frame: CallSite, state: State) {
// from getScriptNameOrSourceURL() instead
const source = frame.getFileName() || frame.getScriptNameOrSourceURL()
if (source) {
const line = frame.getLineNumber() as number
const column = (frame.getColumnNumber() as number) - 1
const line = frame.getLineNumber() ?? 0
const column = (frame.getColumnNumber() ?? 1) - 1
Copy link
Contributor

@graphite-app graphite-app bot Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix does not prevent negative columns in all cases. When getColumnNumber() returns 0 (a valid non-nullish value), the result is still -1 because the nullish coalescing operator (??) only handles null or undefined, not 0. This means negative columns can still occur, contradicting the PR's stated purpose.

To actually prevent negative columns, the code should be:

const column = Math.max(0, (frame.getColumnNumber() ?? 1) - 1)
Suggested change
const column = (frame.getColumnNumber() ?? 1) - 1
const column = Math.max(0, (frame.getColumnNumber() ?? 1) - 1)

Spotted by Graphite Agent

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.


const position = mapSourcePosition({
name: null,
Expand Down
40 changes: 40 additions & 0 deletions packages/vite/src/node/ssr/runtime/__tests__/server-source-maps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { runInThisContext } from 'node:vm'
import { resolve } from 'node:path'
import { describe, expect } from 'vitest'
import type { ViteDevServer } from '../../..'
import type { ModuleRunnerContext } from '../../../../module-runner'
import { ESModulesEvaluator } from '../../../../module-runner'
import {
createFixtureEditor,
createModuleRunnerTester,
Expand Down Expand Up @@ -135,3 +139,39 @@ describe('module runner initialization', async () => {
`)
})
})

describe('module runner with node:vm executor', async () => {
class Evaluator extends ESModulesEvaluator {
async runInlinedModule(_: ModuleRunnerContext, __: string) {
// Mimics VitestModuleEvaluator
const initModule = runInThisContext(
'() => { throw new Error("example")}',
{
lineOffset: 0,
columnOffset: -100,
filename: resolve(import.meta.dirname, 'fixtures/a.ts'),
},
)

initModule()
}
}

const it = await createModuleRunnerTester(
{},
{
sourcemapInterceptor: 'prepareStackTrace',
evaluator: new Evaluator(),
},
)

it('should not crash when error stacktrace contains negative column', async ({
runner,
}) => {
const error = await runner.import('/fixtures/a.ts').catch((err) => err)

expect(() =>
error.stack.includes('.stack access triggers the bug'),
).not.toThrow()
})
})