feat(create-vite): bump eslint-plugin-react-refresh#21534
Open
ArnaudBarre wants to merge 1 commit intomainfrom
Open
feat(create-vite): bump eslint-plugin-react-refresh#21534ArnaudBarre wants to merge 1 commit intomainfrom
ArnaudBarre wants to merge 1 commit intomainfrom
Conversation
Member
What about exporting the default options object from the plugin so that users can manually spread themselves? |
Member
Author
|
Yeah I could also export this. But function are nice because parameters gets TS autocomplete which makes options discoverable, contrary to the default way of configuring ESLint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a major bump to my eslint plugin for multiple reasons.
The configs are now functions which allow users to merge additional settings with the default settings. But ESLint typing forbids this to be on
<default export>.config, so this why a named export it used