fix(preview): guard malformed URI decode in HTML middleware #21313
+28
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
decodeURIComponentis called on untrusted request paths inindexHtmlMiddleware(preview + dev)and
memoryFilesMiddleware(full-bundle dev). Malformed percent-encoding (e.g./foo%ZZ.html)throws
URIError, which propagates out of the middleware and terminates the Node process.Fix
decodeURIComponentcalls with a safe decode helper in the HTML middleware.next()when decoding fails, avoiding a hard crash.decodeURIComponentin memory file serving for the same reason.Reproduction
vite preview --host 127.0.0.1 --port 4175 --strictPortGET /foo%ZZ.html<-- used to crashURIError: URI malformedTesting