fix(deps): downgrade commonjs plugin to 28.0.6 to avoid rollup/plugins#1909

[sapphi-red]

Description

Let's add a revert for now. I'll backport this to 7.1 after this PR is merged.

fixes #20983

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vite@20988

commit: e870983

[sapphi-red]

Oops, the patch is wrong

[sapphi-red]

/ecosystem-ci run

[bluwy]

Should we pin the to previous version instead of patching?

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 1a8ee07: Open

suite	result	latest scheduled
analogjs	❌ failure	✅ success
astro	❌ failure	✅ success
histoire	❌ failure	✅ success
laravel	❌ failure	❌ failure
vite-environment-examples	❌ failure	✅ success
vite-plugin-vue	❌ failure	✅ success
qwik	✅ success	❌ failure
waku	✅ success	❌ failure
react-router	✅ success	⏹️ cancelled
vite-plugin-rsc	❌ failure	❌ failure
storybook	❌ failure	✅ success
vite-plugin-svelte	❌ failure	✅ success
vite-plugin-cloudflare	❌ failure	✅ success
vitest	❌ failure	✅ success

✅ ladle, one, rakkas, marko, vike, nuxt, unocss, vite-plugin-react, sveltekit, vitepress, vite-plugin-pwa, quasar, vuepress, vite-setup-catalogue

[sapphi-red]

Should we pin the to previous version instead of patching?

rollup/plugins#1909 was introduced in 28.0.7 which is two versions older. If we pin the version to 28.0.6, it'll also revert rollup/plugins#1914

[hi-ogawa]

If it's easier, it looks fine to pin the old version for now as a quick fix. Is ecosystem CI failure still related to commonjs plugin or something else?

[hi-ogawa]

Oh, I just realized the same patch is for dist/cjs and dist/esm, so it's a simple revert of rollup PR. Isn't only dist/esm bundled to vite?

[sapphi-red]

Is ecosystem CI failure still related to commonjs plugin or something else?

I think it's not related. This is the run for the main branch: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/18737739165

[sapphi-red]

I'll change to a simple revert as that feels safer.

[bluwy]

We should make sure this isn't accidentally bumped again in the next renovate PR until it's fixed upstream