fix(optimizer): align relative build.rollupOptions.input resolution with rollup

[sapphi-red]

Description

computeEntries resolves relative build.rollupOptions.input from the root.

vite/packages/vite/src/node/optimizer/scan.ts

Lines 244 to 265 in 61b6b96

	const resolvePath = async (p: string) => {
	const id = (
	await environment.pluginContainer.resolveId(p, undefined, {
	scan: true,
	})
	)?.id
	if (id === undefined) {
	throw new Error(
	`failed to resolve rollupOptions.input value: ${JSON.stringify(p)}.`,
	)
	}
	return id
	}
	if (typeof buildInput === 'string') {
	entries = [await resolvePath(buildInput)]
	} else if (Array.isArray(buildInput)) {
	entries = await Promise.all(buildInput.map(resolvePath))
	} else if (isObject(buildInput)) {
	entries = await Promise.all(Object.values(buildInput).map(resolvePath))
	} else {
	throw new Error('invalid rollupOptions.input value.')
	}

vite/packages/vite/src/node/server/pluginContainer.ts

Lines 341 to 344 in 61b6b96

	importer: string | undefined = join(
	this.environment.config.root,
	'index.html',
	),

reproduction: https://stackblitz.com/edit/vitejs-vite-nte18shp?file=package.json,vite.config.js&terminal=dev

On the other hand, rollup resolves relative build.rollupOptions.input from process.cwd().

This PR fixes the computeEntries to align the behavior with rollup. I think we should align with rollup, but that would probably have a bigger impact, so I made that a separate PR.

A workaround is to call path.resolve in the config before passing to build.rollupOptions.input.

reported at #15834 (reply in thread)
refs #20079

[patak-dev]

/ecosystem-ci run

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/vite@20080

commit: 3105302

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 7872cfc: Open

suite	result	latest scheduled
analogjs	❌ failure	❌ failure
laravel	❌ failure	❌ failure
vike	❌ failure	✅ success
vitest	❌ failure	❌ failure

✅ astro, histoire, marko, quasar, nuxt, rakkas, react-router, previewjs, ladle, qwik, sveltekit, storybook, unocss, vuepress, vite-plugin-svelte, waku, vite-setup-catalogue, vite-plugin-pwa, vite-environment-examples, vite-plugin-vue, vite-plugin-cloudflare, vite-plugin-react, vitepress

[sapphi-red]

Hmm, it seems vike fails on this branch and passes on latest main (https://github.com/vitejs/vite-ecosystem-ci/actions/runs/151765559389).
The error is happening in build, which is strange...

[sapphi-red]

It seems pnpm tsx ecosystem-ci.ts vike --repo sapphi-red/vite --branch fix/optimizer-resolve-relative-build-rollupOptions-input passes, but pnpm tsx ecosystem-ci.ts vike --repo sapphi-red/vite --commit 7872cfc6181bd19fe6f42d8990a0ddfa56dbf8f8 fails.

[sapphi-red]

It seems it passes with rollup 4.38.0 and fails with 4.39.0.

[sapphi-red]

OK. pnpm tsx ecosystem-ci.ts vike --repo sapphi-red/vite --branch fix/optimizer-resolve-relative-build-rollupOptions-input sets overrides.rollup: '4.40.1' and pnpm tsx ecosystem-ci.ts vike --repo sapphi-red/vite --commit 7872cfc6181bd19fe6f42d8990a0ddfa56dbf8f8 sets overrides.rollup: '^4.40.0' (because it uses pkg.pr.new), and there was a bug in rollup 4.39.0 - 4.40.0. So the failure is not caused by this PR.

[sapphi-red]

/ecosystem-ci run

[vite-ecosystem-ci]

📝 Ran ecosystem CI on 3105302: Open

suite	result	latest scheduled
analogjs	❌ failure	❌ failure
histoire	❌ failure	❌ failure
astro	❌ failure	❌ failure
previewjs	❌ failure	❌ failure
vike	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
vite-plugin-cloudflare	❌ failure	❌ failure

✅ laravel, react-router, quasar, qwik, ladle, nuxt, unocss, storybook, vite-plugin-pwa, vite-plugin-react, rakkas, vite-environment-examples, vite-setup-catalogue, vitepress, marko, vitest, vite-plugin-svelte, vuepress, waku, vite-plugin-vue

[sapphi-red]

vike is failing with a different error but the reason is same with #20080 (comment) and not caused by this PR.