-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
feat(css): support preprocessor with lightningcss #19071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sapphi-red
merged 6 commits into
vitejs:main
from
sapphi-red:feat/support-preprocessor-with-transformer-lightning-css
Mar 24, 2025
Merged
feat(css): support preprocessor with lightningcss #19071
sapphi-red
merged 6 commits into
vitejs:main
from
sapphi-red:feat/support-preprocessor-with-transformer-lightning-css
Mar 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
fb205e0
to
3e9175d
Compare
3e9175d
to
1f49c1a
Compare
bluwy
previously approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good to me
jrmajor
reviewed
Mar 19, 2025
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
still needs some polishing and some minor bug fixes / features in lightningcss for some edge cases, but it's mostly working
after this PR landed, we should be able to graduate
transformer: 'lightningcss'
from experimentalcloses #19112