test: don't use __dirname in tailwind config#18969
Merged
hi-ogawa merged 1 commit intovitejs:mainfrom Dec 16, 2024
Merged
Conversation
sapphi-red
added a commit
to vitejs/rolldown-vite
that referenced
this pull request
Dec 16, 2024
Contributor
|
How does node 18, 20 work (before and after this PR)? Is it still go to |
Member
Author
|
On node 18 / 20, before this PR, |
hi-ogawa
approved these changes
Dec 16, 2024
Contributor
|
Testing locally, I'm not sure what's happening with |
sapphi-red
deleted the
test/fix-dont-use-__dirname-in-tailwind-config
branch
9 tasks
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
require(esm)is now enabled by default from Node 22.12.0.Before node 22.12.0, the tailwind config was loaded by jiti and that allowed users to use
__dirnamein ESM tailwind configs.But after node 22.12.0,
require(esm)is supported by Node and that is used instead of jiti and thus__dirnameis not declared and errors.https://github.com/tailwindlabs/tailwindcss/blob/f875ab9706cae8262e15e5b382580fc8e2d4197f/src/lib/load-config.ts#L34-L51