feat: show error when accessing variables not exposed in CJS build #18649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p3-minor-bug
sapphi-red
commented
Nov 13, 2024
bluwy
reviewed
Nov 13, 2024
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
previously approved these changes
Nov 13, 2024
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Perhaps we can look into a Rollup plugin or a post-build script that ensures the exports are properly implemented in both ESM and CJS, but I think that can be done later.
Member
Author
|
Added that check (fbcfc1c) 👍 |
sapphi-red
deleted the
feat/show-error-when-accessing-vars-not-expose-in-cjs-build
branch
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
…itejs#18649) Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No error happened when accessing variables not exposed in CJS build. This PR adds an error for that, so the user can know what is needed to do.