Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Add Vite development container configuration #18490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link

Description

This pull request introduces a new development container configuration for the Vite development environment. The primary change is the addition of a devcontainer.json file to facilitate containerized development.

Development container setup:

  • .devcontainer/devcontainer.json: Added a new development container configuration file for Vite, specifying the use of the mcr.microsoft.com/devcontainers/base:jammy image, enabling the pnpm feature, running a post-create command to install dependencies and build the project, and forwarding ports 3000, 5173, and 8080.

This configuration is quite simple and working (I already tested it)

So let's take a look at it and think about whether something should be added or changed

@okineadev okineadev changed the title Add Vite development container configuration feat: ✨ Add Vite development container configuration Oct 28, 2024
@bluwy
Copy link
Member

bluwy commented Oct 28, 2024

Is there a reason to add this? We personally don't use devcontainers and have closed it in the past: #13210

@okineadev
Copy link
Author

Is there a reason to add this? We personally don't use devcontainers and have closed it in the past: #13210

I still think it's better to add it, because there are people who use it, besides, I didn't know what stackblitz was at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants