fix: upgrade rollup 4.22.2, deterministic chunk hashing fix #18151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently encountered an issue where hashes produced by
rollup
were non-deterministic when collisions occur. A fix has been upstreamed torollup
to resolve this and was released in version4.22.2
. Our application currently has a patch to mitigate this issue, so by upgradingrollup
we can remove it.More details about the issue and resolution within
rollup
can be found in the following PR: rollup/rollup#5644Looking over the rollup releases, I am not seeing any change that would require an implementation change to vite. So, it seems this should be safe to upgrade.