Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit vite:preloadError for chunks without deps #15203

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sapphi-red
Copy link
Member

Description

If the loaded chunk didn't have any deps, vite:preloadError was not emitted.

For example, the event is not emitted for https://stackblitz.com/edit/vitejs-vite-ho9n9z?file=main.js,counter.js and is emitted for https://stackblitz.com/edit/vitejs-vite-eubg1i?file=main.js,counter.js
The difference between them is that counter.js imports counter.css in the latter one.

refs #12084

/cc @danielroe

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 1, 2023
Copy link

stackblitz bot commented Dec 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Member Author

I think we should add a section about vite:preloadError somewhere in the docs, but I'm not sure where to put this. 🤔
The related sections to vite:preloadError are:

@patak-dev
Copy link
Member

I think we can add the section in the docs in another PR. Maybe another section after Chunking Strategy? (we could also think of removing the vendor plugin bits from Chunking Strategy, it may not be needed there anymore)

@patak-dev patak-dev merged commit d8001c5 into vitejs:main Dec 1, 2023
10 checks passed
@sapphi-red sapphi-red deleted the fix/preload-error-no-deps branch December 1, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants