fix: skip watchPackageDataPlugin for worker builds #14762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The actual fix instead of #14751 (the PR did nothing)
The issue was that
this.addWatchFile
was brought outside the scope ofbuildStart
by the plugin:vite/packages/vite/src/node/packages.ts
Lines 243 to 247 in 521ca58
So Rollup wasn't able to catch the error and pass it to
onwarn
for filtering (and I also think it should beonLog
now). The error is invoked outside the scope:vite/packages/vite/src/node/packages.ts
Lines 233 to 239 in 521ca58
Additional context
It's a bit hard to reproduce this so I thought the other PR fixed it. But I think this PR should fix it for real now.
What is the purpose of this pull request?