Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wasm): remove unnecessary conditional statement #14580

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Oct 11, 2023

Description

Buffer.from(string[, encoding]) is supported in node 5.10.0 version, earlier than atob. Therefore, I think this if statement is unnecessary.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member

sapphi-red commented Oct 11, 2023

This wasmHelper function is included in the output bundle and could run in browser or node (SSR). Because Buffer doesn't exist in browsers we'll need to have a fallback.
Ideally we should use a different function for non-SSR and SSR (#8882).

BTW fetch supports data URI so we can use fetch for data uri as well in browsers.

@btea
Copy link
Collaborator Author

btea commented Oct 11, 2023

OK, I got it, thank you for your explanation. 👍

@btea btea closed this Oct 11, 2023
@btea btea deleted the chore/clean-wasm branch October 11, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants