fix: disable code splitting for optimized dependencies #14249
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables code splitting for optimized dependencies.
Fixes #12423.
Fixes #5142.
Additional context
The esbuild docs say that "code splitting is still a work in progress...with a known ordering issue" and is not "ready for use in production yet". The ordering issue has been around for several years with no end in sight.
It seems problematic to rely on a feature from esbuild that is known to have issues and therefore causes issues for the users of Vite.
See #12423 (comment) for more context.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).