-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(importMetaGlob): avoid unnecessary hmr of negative glob #13646
Conversation
Run & review this pull request in StackBlitz Codeflow. |
allGlobs.some( | ||
({ affirmed, negated }) => | ||
affirmed.some((glob) => isMatch(file, glob)) && | ||
negated.every((glob) => !isMatch(file, glob)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
negated.every((glob) => !isMatch(file, glob)), | |
negated.every((glob) => isMatch(file, glob)), |
I think this !
should be removed. I initially made this mistake but corrected in #13646 (comment).
For example, if negated
is ['!foo.js', '!bar.js']
, then isMatch('baz.js', glob)
will return true
for all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see.
This remind me that code below maybe more robust ?
(!affirmed.length || affirmed.some((glob) => isMatch(file, glob))) &&
(!negated.length || negated.every((glob) => isMatch(file, glob)))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Description
fix #13374
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).