Skip to content

Conversation

@Saeed-Paris
Copy link
Contributor

Description

nothing fancy or important. just noticed that buildSsrCjsExternalHeuristics function had same statement in both if and else (Hope this wasn't a wierd edge case)

Happy first Vite contribution 🥳🥳🥳


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

format = 'cjs'
} else {
format = 'cjs'
if (!ssr) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target is already 'node', we can remove this condition too. Note: We plan to remove CJS external heuristics support in Vite 5. If you are using it for some reason, please comment on #12466. We hope to move to ESM only for SSR as all services now properly support ESM.

@Saeed-Paris Saeed-Paris force-pushed the refactore-ssr-options branch from d7acd98 to 668ec2c Compare May 19, 2023 04:36
@patak-dev patak-dev merged commit 8013a66 into vitejs:main May 22, 2023
@Saeed-Paris Saeed-Paris deleted the refactore-ssr-options branch May 23, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants